Include cerrno header explictly#99
Merged
sparkprime merged 1 commit intogoogle:masterfrom Feb 3, 2016
Merged
Conversation
It will fail to build in FreeBSD 9.3 if we don't require cerrno
header for using variable `errno`.
$ g++48 --version
g++48 (FreeBSD Ports Collection) 4.8.5
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is
NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
PURPOSE.
$ root@9_3amd64-local:/usr/ports/devel/jsonnet # uname -a
FreeBSD 9_3amd64-local 9.3-RELEASE-p36 FreeBSD 9.3-RELEASE-p36 amd64
$ make
===> Building for jsonnet-0.8.6
g++48 -c -O2 -pipe -fstack-protector -Wl,-rpath=/usr/local/lib/gcc48
-fno-strict-aliasing -fPIC -Iinclude -std=c++11 core/libjsonnet.cpp
-o core/libjsonnet.o
core/libjsonnet.cpp: In function 'ImportStatus try_path(const string&,
const string&, std::string&, std::string&, std::string&)':
core/libjsonnet.cpp:112:28: error: 'errno' was not declared in this
scope
err_msg = strerror(errno);
^
sparkprime
added a commit
that referenced
this pull request
Feb 3, 2016
Include cerrno header explictly
This was referenced Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will fail to build in FreeBSD 9.3 if we don't require cerrno
header for using variable
errno.